feat: add all supported alogithms for rsa-enc keystore #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
force-pushed
the
keystore-rsa-algorithms
branch
from
dbc9c21 to
4700bb0
Compare
|
Funny that the tests have been working before, should we split the |
tboerger
force-pushed
the
keystore-rsa-algorithms
branch
2 times, most recently
from
002660e to
1f72340
Compare
|
I have split the valid alorithms and tried to add some basic testing for both variants. |
tboerger
force-pushed
the
keystore-rsa-algorithms
branch
2 times, most recently
from
f898a0a to
32961df
Compare
Signed-off-by: Thomas Boerger <[email protected]>
Signed-off-by: Thomas Boerger <[email protected]>
tboerger
force-pushed
the
keystore-rsa-algorithms
branch
from
32961df to
2c48016
Compare
|
Getting some review for this PR would be pretty great, so far it's not possible to configure supported encryption keys via Terraform. |
|
@tboerger I'll have a look later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simply all algorithms which are available for keystores based on rsa-enc provider. Currently it got only a single one while there are 3 different available.